Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui5-select): remove unused css vars #10789

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

dobrinyonkov
Copy link
Contributor

@dobrinyonkov dobrinyonkov commented Feb 6, 2025

The Select component is reusing the input styles, there were still some vars which were not removed.

@ilhan007 ilhan007 merged commit be6c619 into main Feb 6, 2025
11 of 12 checks passed
@ilhan007 ilhan007 deleted the select-css-vars-cleanup branch February 6, 2025 16:07
dobromiraboycheva added a commit that referenced this pull request Feb 11, 2025
…ui5-settings

* 'main' of https://github.com/SAP/ui5-webcomponents:
  refactor(ui5-multi-combobox): switch to .tsx (#10807)
  refactor(ListItem): delete unused code (#10796)
  chore(deps-dev): bump esbuild from 0.19.9 to 0.25.0 (#10816)
  chore(deps-dev): bump vitest from 3.0.2 to 3.0.5 (#10785)
  test: add command for single cy test run (#10813)
  docs: fix TimelineGrowingMode enum docs (#10815)
  fix(ui5-side-navigation): remove inappropriate exclamation mark usage (#10769)
  feat(ui5-link): introduce reactive area size property (#10762)
  fix(ui5-side-navigation): "Space" key triggers links (#10767)
  chore(ui5-timeline): importing a timeline group item in the samples (#10793)
  chore: add ElementInternals shim (#10782)
  chore: fix MultiInput test (#10791)
  Translation Delivery (#10772)
  chore(ui5-select): remove unused css vars (#10789)
  chore: warn when scoping suffix is set too late (#10781)
  fix(ui5-button): remove tap highlight on safari (#10786)
  feat(ui5-table): action header cell is added (#10698)
  docs: fix List sample
  chore(release): publish v2.8.0-rc.0 [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants