Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-side-navigation): "Space" key triggers links #10767

Merged
merged 8 commits into from
Feb 10, 2025
+104 −3
Merged

fix(ui5-side-navigation): "Space" key triggers links #10767

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a26b1ae
fix(ui5-side-navigation): "Space" key triggers links
LidiyaGeorgieva Feb 4, 2025
f4f333e
chore: split fixes
LidiyaGeorgieva Feb 4, 2025
4621578
chore: fix tests
LidiyaGeorgieva Feb 5, 2025
4e5d308
chore: add keyup test
LidiyaGeorgieva Feb 5, 2025
dd8905d
chore: adapt test
LidiyaGeorgieva Feb 6, 2025
65dce29
chore: fix test
LidiyaGeorgieva Feb 6, 2025
4e8f2b9
Merge branch 'main' of https://github.com/SAP/ui5-webcomponents into …
LidiyaGeorgieva Feb 6, 2025
4546461
chore: fix test
LidiyaGeorgieva Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
chore: fix test
@LidiyaGeorgieva
LidiyaGeorgieva committed Feb 7, 2025
commit 454646106f8c7ff298549cf1bc2b6f87c364158b
5 changes: 2 additions & 3 deletions packages/fiori/cypress/specs/SideNavigation.cy.tsx
View file
Original file line number Diff line number Diff line change
@@ -379,12 +379,11 @@ describe("Side Navigation interaction", () => {

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("Space");
cy.get("#linkItem").should("be.focused");

// act
cy.focused().trigger("keydown", {
key: "Enter",
cy.focused().trigger("keyup", {
key: " ",
});

cy.url().should("include", "#test");