Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-side-navigation]: keyboard handling does not work well for external links #10654

Closed
1 task done
alexandar-mitsev opened this issue Jan 24, 2025 · 0 comments
Closed
1 task done

[ui5-side-navigation]: keyboard handling does not work well for external links #10654

alexandar-mitsev opened this issue Jan 24, 2025 · 0 comments
Assignees
@LidiyaGeorgieva
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@alexandar-mitsev
Copy link
Contributor

Bug Description

Go to the side navigation sample: https://sap.github.io/ui5-webcomponents/nightly/components/fiori/SideNavigation/.

  1. You can not activate an external link by pressing "Space"
  2. If side navigation is collapsed and you have an external link in the second level - as a child, you can not activate it neither with "Space", nor with "Enter"

Affected Component

ui5-side-navigation

Expected Behaviour

Pressing "Enter" or "Space" should activate the external link in all cases.

Isolated Example

No response

Steps to Reproduce

  1. Open https://sap.github.io/ui5-webcomponents/nightly/components/fiori/SideNavigation/
  2. Edit the sample and add "collapsed" to the ui5-side-navigation
  3. Navigate using the keyboard
  4. Go to second item "External Link"
  5. Press "Space" - it is not activated
  6. Go to last element "Events"
  7. Open the children menu
  8. Navigate to "External Link" item
  9. Press "Space" or "Enter" - it is not activated

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.7.0-rc.1

Browser

Chrome

Operating System

Windows

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@alexandar-mitsev alexandar-mitsev added the bug This issue is a bug in the code label Jan 24, 2025
@alexandar-mitsev alexandar-mitsev mentioned this issue Jan 24, 2025
Merged
LidiyaGeorgieva added a commit that referenced this issue Feb 4, 2025
@LidiyaGeorgieva
fix(ui5-side-navigation): "Space" key triggers links
a26b1ae 
Pressing "Space" key triggers click on the items with external links.
In addition inappropriate exclamation mark usage removed.

fixes: #10654
fixes: #10714
@LidiyaGeorgieva LidiyaGeorgieva mentioned this issue Feb 4, 2025
Merged
LidiyaGeorgieva added a commit that referenced this issue Feb 10, 2025
@LidiyaGeorgieva
fix(ui5-side-navigation): "Space" key triggers links (#10767)
b2ab592 
Pressing "Space" key triggers click on the items with external links.

relates: #10654
@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic RD Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LidiyaGeorgieva LidiyaGeorgieva

Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexandar-mitsev @LidiyaGeorgieva