Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatar]: attribute accessibleName doesn't seem to have any effect #10461

Closed
1 task done
gurkirpalgill opened this issue Jan 3, 2025 · 3 comments · Fixed by #10854
Closed
1 task done

[Avatar]: attribute accessibleName doesn't seem to have any effect #10461

gurkirpalgill opened this issue Jan 3, 2025 · 3 comments · Fixed by #10854
Assignees
Labels
bug This issue is a bug in the code released TOPIC P

Comments

@gurkirpalgill
Copy link

Bug Description

When using accesssibleName/accessible-name attribute along with icon attribute in Avatar component it doesn't seem to have any effect on the svg image.
axe-Devtools complaints Ensure <svg> elements with an img, graphics-document or graphics-symbol role have an accessible text

Affected Component

Avatar

Expected Behaviour

When using accessibleName attribute along with icon attribute, aria-label should be propagated to the svg image tag. see attached screenshots.

Image
Image
Image

Isolated Example

No response

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.x

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@gurkirpalgill gurkirpalgill added the bug This issue is a bug in the code label Jan 3, 2025
@GerganaKremenska GerganaKremenska self-assigned this Jan 6, 2025
@GerganaKremenska
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-p,

There is an issue rasied by the AXE tool for the ui5-avatar, when accessible-name is set.
Setps to reproduce:

  1. open link
  2. Run axe dev tools

Error is raised that svg element does not have an accessible text.

As I can see the accessible name is applied to the wrapper element of the avatar with role="img", but on the svg it self the is no accessible name.

Can you take over?

Best Regards,
Gergana

@GerganaKremenska
Copy link
Member

Hello @gurkirpalgill,

accessible-name is the correct way to set a property.
accessibleName will not be regognized by the framework.

Best Regards,
Gergana

@GerganaKremenska GerganaKremenska removed their assignment Jan 6, 2025
@yanaminkova yanaminkova self-assigned this Jan 10, 2025
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova moved this from Issues to In Progress in Maintenance - Topic P Jan 13, 2025
yanaminkova added a commit that referenced this issue Feb 14, 2025
Now, when the ui5-avatar is used with an icon, its accessible-name is correctly set at the SVG level, ensuring proper announcement.

Fixes: #10461
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Feb 14, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.8.0-rc.2 🎉

The release is available on v2.8.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code released TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants