fix(AnalyticalTable): update column header icons to align with latest spec #6598
+24
−7
Next
Next commit
Fix(AnalyticalTable): update column header icons to align with latest…
… spec
commit f4a95c64371dfe4c36e30e2c3b26d2225fe74ea8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -49,3 +49,8 @@ | ||
| display: flex; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .icon { | ||
| height: 0.8rem; | ||
| width: 0.8rem; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function ResizeTestComponent({ onChange }: { onChange: (event: { width: number; height: number }) => void }) { | ||
| useEffect(() => { | ||
| attachResizeHandler(onChange); | ||
| }, []); | ||
| const unregister = () => { | ||
| detachResizeHandler(onChange); | ||
| }) { | ||
| useEffect(() => { | ||
| attachOrientationChangeHandler(onChange); | ||
| }, []); | ||
| const unregister = () => { | ||
| detachOrientationChangeHandler(onChange); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param measure {IChartMeasure} Current measure object | ||
| * @param dataElement {object} Current data element | ||
| */ | ||
| highlightColor?: (value: number, measure: MeasureConfig, dataElement: Record<string, any>) => CSSProperties['color']; | ||
| } | ||
| interface DimensionConfig extends IChartDimension { | ||
| ? dataKeys.findIndex((key) => key === chartConfig.secondYAxis?.dataKey) | ||
| : 0; | ||
| const [componentRef, chartRef] = useSyncRef<any>(ref); | ||
| const onItemLegendClick = useLegendItemClick(onLegendClick); | ||
| const labelFormatter = useLabelFormatter(primaryDimension); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| speed={2} | ||
| backgroundColor={ThemingParameters.sapContent_ImagePlaceholderBackground} | ||
| foregroundColor={ThemingParameters.sapContent_ImagePlaceholderForegroundColor} | ||
| backgroundOpacity={ThemingParameters.sapContent_DisabledOpacity as any} | ||
| > | ||
| <rect x="20" y="10" width="1" height="135" /> | ||
| <rect x="20" y="20" width="85" height="15" /> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param measure {IChartMeasure} Current measure object | ||
| * @param dataElement {object} Current data element | ||
| */ | ||
| highlightColor?: (value: number, measure: MeasureConfig, dataElement: Record<string, any>) => CSSProperties['color']; | ||
| } | ||
| interface DimensionConfig extends IChartDimension { | ||
| ...rest | ||
| } = props; | ||
| const [componentRef, chartRef] = useSyncRef<any>(ref); | ||
| const chartConfig = { | ||
| yAxisVisible: false, | ||
| ); | ||
| } else { | ||
| onDataPointClick( | ||
| enrichEventWithDetails({} as any, { | ||
| value: eventOrIndex.value, | ||
| dataKey: eventOrIndex.dataKey, | ||
| dataIndex: eventOrIndex.index, | ||
| {chartConfig.xAxisVisible && | ||
| dimensions.map((dimension, index) => { | ||
| let AxisComponent; | ||
| const axisProps: any = { | ||
| dataKey: dimension.accessor, | ||
| interval: dimension?.interval ?? (isBigDataSet ? 'preserveStart' : 0), | ||
| tickLine: index < 1, | ||
| /> | ||
| )} | ||
| {sortedMeasures?.map((element, index) => { | ||
| const chartElementProps: any = { | ||
| isAnimationActive: noAnimation === false | ||
| }; | ||
| let labelPosition = 'top'; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this result in subpixels which might cause weird rendering issues?