fix(ObjectPageSubSection): update styles to latest specs

SAP · Lukas742 · Oct 16, 2024 · Oct 15, 2024 · Oct 15, 2024 · bcf54817a86b15b87e43f7d1b13fe472fbfe39a8
commit bcf54817a86b15b87e43f7d1b13fe472fbfe39a8
@@ -18,6 +18,7 @@
 }
 
 .subSectionTitle {
+  font-family: var(--sapFontHeaderFamily);
   font-size: var(--sapFontHeader5Size);
   color: var(--sapGroup_TitleTextColor);
   flex-grow: 1;
@@ -26,7 +27,6 @@
 .subSectionContent {
   background-color: var(--_ui5wcr_ObjectPage_SubSectionBackgroundColor);
   border-radius: var(--_ui5wcr_ObjectPage_SubSectionBorderRadius);
-  padding-inline: 0.5rem;
   padding-block: 1rem;
 }
 

diff --git a/packages/base/src/Device/index.cy.tsx b/packages/base/src/Device/index.cy.tsx
 function ResizeTestComponent({ onChange }: { onChange: (event: { width: number; height: number }) => void }) {
  useEffect(() => {
    attachResizeHandler(onChange);
  }, []);

  const unregister = () => {
    detachResizeHandler(onChange);
 }) {
  useEffect(() => {
    attachOrientationChangeHandler(onChange);
  }, []);

  const unregister = () => {
    detachOrientationChangeHandler(onChange);
diff --git a/packages/charts/src/components/BarChart/BarChart.tsx b/packages/charts/src/components/BarChart/BarChart.tsx
   * @param measure {IChartMeasure} Current measure object
   * @param dataElement {object} Current data element
   */
  highlightColor?: (value: number, measure: MeasureConfig, dataElement: Record<string, any>) => CSSProperties['color'];
 }

 interface DimensionConfig extends IChartDimension {
    ? dataKeys.findIndex((key) => key === chartConfig.secondYAxis?.dataKey)
    : 0;

  const [componentRef, chartRef] = useSyncRef<any>(ref);

  const onItemLegendClick = useLegendItemClick(onLegendClick);
  const labelFormatter = useLabelFormatter(primaryDimension);
diff --git a/packages/charts/src/components/BarChart/Placeholder.tsx b/packages/charts/src/components/BarChart/Placeholder.tsx
      speed={2}
      backgroundColor={ThemingParameters.sapContent_ImagePlaceholderBackground}
      foregroundColor={ThemingParameters.sapContent_ImagePlaceholderForegroundColor}
      backgroundOpacity={ThemingParameters.sapContent_DisabledOpacity as any}
    >
      <rect x="20" y="10" width="1" height="135" />
      <rect x="20" y="20" width="85" height="15" />
diff --git a/packages/charts/src/components/BulletChart/BulletChart.tsx b/packages/charts/src/components/BulletChart/BulletChart.tsx
   * @param measure {IChartMeasure} Current measure object
   * @param dataElement {object} Current data element
   */
  highlightColor?: (value: number, measure: MeasureConfig, dataElement: Record<string, any>) => CSSProperties['color'];
 }

 interface DimensionConfig extends IChartDimension {
    ...rest
  } = props;

  const [componentRef, chartRef] = useSyncRef<any>(ref);

  const chartConfig: BulletChartProps['chartConfig'] = {
    yAxisVisible: false,
          );
        } else {
          onDataPointClick(
            enrichEventWithDetails({} as any, {
              value: eventOrIndex.value,
              dataKey: eventOrIndex.dataKey,
              dataIndex: eventOrIndex.index,
        {chartConfig.xAxisVisible &&
          dimensions.map((dimension, index) => {
            let AxisComponent;
            const axisProps: any = {
              dataKey: dimension.accessor,
              interval: dimension?.interval ?? (isBigDataSet ? 'preserveStartEnd' : 0),
              tickLine: index < 1,
          />
        )}
        {sortedMeasures?.map((element, index) => {
          const chartElementProps: any = {
            isAnimationActive: !noAnimation
          };
          let labelPosition = 'top';
	function ResizeTestComponent({ onChange }: { onChange: (event: { width: number; height: number }) => void }) {
	useEffect(() => {
	attachResizeHandler(onChange);
	}, []);
Check warning on line 12 in packages/base/src/Device/index.cy.tsx GitHub Actions / lint `React Hook useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array`

	const unregister = () => {
	detachResizeHandler(onChange);
	}) {
	useEffect(() => {
	attachOrientationChangeHandler(onChange);
	}, []);
Check warning on line 32 in packages/base/src/Device/index.cy.tsx GitHub Actions / lint `React Hook useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array`

	const unregister = () => {
	detachOrientationChangeHandler(onChange);
	* @param measure {IChartMeasure} Current measure object
	* @param dataElement {object} Current data element
	*/
	highlightColor?: (value: number, measure: MeasureConfig, dataElement: Record<string, any>) => CSSProperties['color'];
Check warning on line 79 in packages/charts/src/components/BarChart/BarChart.tsx GitHub Actions / lint `Unexpected any. Specify a different type`
	}

	interface DimensionConfig extends IChartDimension {
	? dataKeys.findIndex((key) => key === chartConfig.secondYAxis?.dataKey)
	: 0;

	const [componentRef, chartRef] = useSyncRef<any>(ref);
Check warning on line 189 in packages/charts/src/components/BarChart/BarChart.tsx GitHub Actions / lint `Unexpected any. Specify a different type`

	const onItemLegendClick = useLegendItemClick(onLegendClick);
	const labelFormatter = useLabelFormatter(primaryDimension);
	speed={2}
	backgroundColor={ThemingParameters.sapContent_ImagePlaceholderBackground}
	foregroundColor={ThemingParameters.sapContent_ImagePlaceholderForegroundColor}
	backgroundOpacity={ThemingParameters.sapContent_DisabledOpacity as any}
Check warning on line 15 in packages/charts/src/components/BarChart/Placeholder.tsx GitHub Actions / lint `Unexpected any. Specify a different type`
	>
	<rect x="20" y="10" width="1" height="135" />
	<rect x="20" y="20" width="85" height="15" />