Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnalyticalTable]: [In entire application for ‘XX’ column header within ‘XX’ table, 4 sided borders are not properly visible, it is visible in dotted border for the users and when we selecting any header row only 3 sided border are visible.] #5898

Closed
1 task done
jadhavarjun opened this issue Jun 7, 2024 · 10 comments · Fixed by #5944
Labels

Comments

@jadhavarjun
Copy link

Describe the bug

In entire application for ‘XX’ column header within ‘XX’ table, 4 sided borders are not properly visible, it is visible in dotted border for the users and when we selecting any header row only 3 sided border are visible.

Link: https://sap.github.io/ui5-webcomponents-react/?path=/story/data-display-analyticaltable--default&args=sortable:!false;filterable:!false;groupable:!false&globals=theme:sap_horizon_hcb

Reproduction steps:

  1. After clicking on link choose Horizon High Contrast Black/Horizon High Contrast White Theme
  2. Click on any table row data you will able to see the selected that selected text 4 sided borders are not properly visible, it is visible in dotted border.

Isolated Example

No response

Reproduction steps

...

Expected Behaviour

User should be able to see 4-sided borders for the UIs and the focus should be strong for all the corners.

Screenshots or Videos

image

UI5 Web Components for React Version

^1.16.3

UI5 Web Components Version

^1.14.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@jadhavarjun
Copy link
Author

Hi @Lukas742,

As you merged the PR (#5944 ) but the issue is still not resolved, Still 4 sided borders are not properly visible, it is visible in dotted border.

Expected behavior: User should be able to see 4-sided borders for the UIs and the focus should be strong for all the corners.

border issue 1

@Lukas742
Copy link
Contributor

Hi @jadhavarjun

merging a PR only means that the commit made it's way to our codebase, not that it has been published. So, the fix will only be available with our next release.

Lukas742 added a commit that referenced this issue Jun 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ls (#5973)

related to #5898
Lukas742 added a commit that referenced this issue Jun 26, 2024
…ls (#5973)

related to #5898
@sanjayC5373903
Copy link

Hi @Lukas742 Could you please let me know when it will next release. and after release what should necessary changes we need to do from our site.

@Lukas742
Copy link
Contributor

Lukas742 commented Jun 27, 2024

Hi @sanjayC5373903

we will most likely release a new version tomorrow or early next week.
Since this is only a bug fix, all you need to do is update your dependencies. :)

@Lukas742
Copy link
Contributor

🎉 This issue has been resolved in version v1.29.3 🎉

The release is available on v1.29.3

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.0.0-rc.0 🎉

The release is available on v2.0.0-rc.0

Your semantic-release bot 📦🚀

@sanjayC5373903
Copy link

Hi @Lukas742
How can i check this issue. could you please provide url or detail for testing this border related issue.

@Lukas742
Copy link
Contributor

Hi @sanjayC5373903

the fix is available in both version 1.29.3 and our pre release version 2.0.0-rc.0, so to test it you have to update your dependencies.

@sanjayC5373903
Copy link

Hi @Lukas742
Thanks for response. Just for confirmation. Can i see this changes on UI5component storybook ?  because I can't see here https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-analyticaltable--docs&globals=theme:sap_horizon_hcb

There above in right corner v1.29.4 version in storybook

@Lukas742
Copy link
Contributor

Lukas742 commented Jul 17, 2024

Yes, the changes are there. The focus border now uses the correct offset in every theme and is not overlapping the cell border (e.g. when selected & focused) anymore.
Could you elaborate on what fix you expected and what is still missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

4 participants