poly1305: Use UniversalHash trait #5
Merged
+120
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
poly1305/use-universal-hash-trait
branch
from
fe227e6 to
55f495b
Compare
|
There are definitely a lot of ways this could be improved, since it's shoehorning the block-based API on the (buffering) slice-based one. I'd like to play around with actually using this with ChaCha20Poly1305 AEAD first and tweaking the implementation a little bit before merging. If all we care about are the AEAD modes, we could get rid of the internal buffering entirely, I think, but I need to confirm that. |
tarcieri
force-pushed
the
poly1305/use-universal-hash-trait
branch
2 times, most recently
from
9fc995e to
c494ab7
Compare
A first pass at adapting Poly1305 to use the `UniversalHash` trait
tarcieri
force-pushed
the
poly1305/use-universal-hash-trait
branch
from
c494ab7 to
299eff8
Compare
|
On second thought, I think this is ok as a first pass. I'll do a follow up after playing around with ChaCha20Poly1305 AEAD before doing another release, though. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first pass at adapting Poly1305 to use the
UniversalHashtrait