ghash: Split from polyval crate
#10
Merged
+405
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ghash
branch
3 times, most recently
from
aa11014 to
e1d9219
Compare
This extracts `ghash` into its own crate. In attempting to add runtime detection to `polyval`, having `ghash` in the same crate felt in-the-way. In this commit, I have split the two crates in advance, and then I'll rebase my runtime detection into its own commit. I think we only need two crates here, as the `ghash` crate is implemented in terms of POLYVAL's field/polynomial: `GHASH(H, X_1, ..., X_n)` => `ByteReverse(POLYVAL(mulX_POLYVAL(ByteReverse(H)), ByteReverse(X_1), ..., ByteReverse(X_n)))` Though they are both GF(2^128), there are some slight discrepancies in the field arithmetic owing to the polynomial, and this approach leverages the fact that the POLYVAL polynomial is the "reverse" of the GHASH one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts
ghashinto its own crate.In attempting to add runtime detection to
polyval, havingghashin the same crate felt in-the-way. In this commit, I have split the two crates in advance, and then I'll rebase my runtime detection into its own commit.I think we only need two crates here, as the
ghashcrate is implemented in terms of POLYVAL's field/polynomial:GHASH(H, X_1, ..., X_n)=>ByteReverse(POLYVAL(mulX_POLYVAL(ByteReverse(H)), ByteReverse(X_1), ..., ByteReverse(X_n)))Though they both operate over GF(2^128), there are some slight discrepancies in the field arithmetic owing to the polynomial, and this approach leverages the fact that the POLYVAL polynomial is the "reverse" of the GHASH one.