Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
xcb
andxcb-util
crates withx11rb
. We were using an old version of thexcb
crate which had some soundness issue.x11rb
doesn't have these issues and generally provides a safer and nicer to use API.It's possible to use
x11rb
without linking to xcb at all, using theRustConnection
API, but unfortunately we have to use theXCBConnection
API (which uses xcb under the hood) due to our use of the xlib GLX API for creating OpenGL contexts. In the future, it might be possible to avoid linking to xlib and xcb by replacing GLX with EGL.Getting the xlib-xcb integration to work also necessitated upgrading the version of the
x11
crate, since the version we were using was missing some necessary functionality that was previously being provided by thexcb
crate.