make SdlDrop zero sized and use more conventional field name #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonilol
added a commit
to antonilol/sdl3-rs
that referenced
this pull request
Feb 10, 2025
revmischa
pushed a commit
to vhspace/sdl3-rs
that referenced
this pull request
Feb 10, 2025
* Reset IS_MAIN_THREAD_DECLARED on drop see Rust-SDL2/rust-sdl2@3395e4e * make Sdl and subsystem structs zero sized based on Rust-SDL2/rust-sdl2#1404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field
_anticonstructoris always initialized with the same value (null pointer), so may be zero sized as well.SdlDrop will remain !Send and !Sync with a pointer inside PhantomData.