ENH: Display more information in MonteCarlo prints and plots

[EvanMad]

Pull request type

• Code changes (bugfix, features)

Checklist

• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant)

Current behavior

Prints maximum, minimum, mean, std dev
Plots ^ parameters with histograms

New behavior

Prints maximum, minimum, mean, std dev, 95% PI Lower, 95% PI Upper
Plots ^ parameters with histograms and boxplots

Breaking change

• Yes
• No

Additional information

For issue #730

[Gui-FernandesBR]

@EvanMad tks for your submission.

I've noticed this PR is duplicated with #753 , therefore we will have to think decide how to proceed, either merging both PRs into one or selecting just one of them.

[Gui-FernandesBR]

Overall it is looking good

[EvanMad]

Apologies for duplicate. I saw that before opening the PR but it seemed like it was unfinished and contained errors

I believe this PR gets closer to resolving the original issue by combining the graphs onto the same plot

Let me know anything I can do to resolve this

[Gui-FernandesBR]

Apologies for duplicate. I saw that before opening the PR but it seemed like it was unfinished and contained errors

I believe this PR gets closer to resolving the original issue by combining the graphs onto the same plot

Let me know anything I can do to resolve this

No problems. Your approach looks good. Once again, thanks for your submission.

[Gui-FernandesBR]

@EvanMad our team is officially on vacations until January 6th.
We appreciate your patience when waiting for the final review.

Meanwhile, what you could already do is to solve linter issues pointed out by the GitHub Actions CI, or also solving the merge conflicts error.

[Lucas-Prates]

Thank you for your interest in solving this issue, @EvanMad. Overall, things look great to me! I was able to reproduce your plot when running the monte carlo usage notebook with the newest version (3.10) of matplotlib, which is good. Here are some remarks:

1. I encountered an issue when trying to call the plots.all method with version 3.5 of matplotlib, see image (1). This might be a problem since the current minimum requirement for matplotlib in our project is >=3.0 . If you wish to reproduce the error, install matplotlib==3.5 in a venv and run the monte carlo usage notebook;
2. This is merely for aesthetic reasons: we could remove the x-axis ticks, y-axis ticks, and x-axis label from the box plot, circled in red ellipsis in image (2); (unifying the plot titles might be a good idea as well, but nevermind this for now)

Image (1) - Error when plotting with version 3.5 of matplotlib

Image (2) - Suggested elements to be removed from the plot

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (83aa20e) to head (00148bc).
Report is 10 commits behind head on develop.

Files with missing lines	Patch %	Lines
rocketpy/simulation/monte_carlo.py	44.44%	5 Missing ⚠️
rocketpy/prints/monte_carlo_prints.py	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #760      +/-   ##
===========================================
- Coverage    76.42%   76.33%   -0.09%     
===========================================
  Files           95       96       +1     
  Lines        11090    11473     +383     
===========================================
+ Hits          8475     8758     +283     
- Misses        2615     2715     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gui-FernandesBR]

LGTM,

@Lucas-Prates is the statistical side looking good to you as well?