Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix export ellipses to kml function #712

Merged
merged 6 commits into from
Nov 2, 2024
Merged

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Enter text here...

New behavior

Enter text here...

Breaking change

  • Yes
  • No

Additional information

Enter text here...

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner October 12, 2024 02:45
@Gui-FernandesBR Gui-FernandesBR linked an issue Oct 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 15 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (13e66f6) to head (6d7a537).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/plots/monte_carlo_plots.py 52.63% 9 Missing ⚠️
rocketpy/simulation/monte_carlo.py 81.81% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #712      +/-   ##
===========================================
+ Coverage    75.88%   75.95%   +0.06%     
===========================================
  Files           99       99              
  Lines        11222    11237      +15     
===========================================
+ Hits          8516     8535      +19     
+ Misses        2706     2702       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR merged commit 282e54e into develop Nov 2, 2024
8 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/kml-ellipses branch November 2, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

BUG: Fix the export ellipses to kml feature
2 participants