-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Adds GenericMotor.load_from_eng_file() method #676
ENH: Adds GenericMotor.load_from_eng_file() method #676
Conversation
582857f
to
fb7d0b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #676 +/- ##
===========================================
- Coverage 75.87% 74.47% -1.41%
===========================================
Files 85 89 +4
Lines 10085 10369 +284
===========================================
+ Hits 7652 7722 +70
- Misses 2433 2647 +214 ☔ View full report in Codecov by Sentry. |
…g file by default if eng file exists)
…s / R0915, row 1218.
…reation of tests for the method, creation of documentation as well
25441bd
to
71204ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really solid work, @juliomachad0 !! The new documentation page was really necessary and I believe it is going to help new users quite a lot!
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCurrent behavior
the static method to create motors from eng files did not exist.
New behavior
method created and working
Breaking change