Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adds GenericMotor.load_from_eng_file() method #676

Merged

Conversation

juliomachad0
Copy link
Member

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally

Current behavior

the static method to create motors from eng files did not exist.

New behavior

method created and working

Breaking change

  • No

@juliomachad0 juliomachad0 requested a review from a team as a code owner August 24, 2024 06:03
@Gui-FernandesBR Gui-FernandesBR force-pushed the enh/motor_parameters_from_eng_files_by_default branch from 582857f to fb7d0b0 Compare August 25, 2024 20:54
@juliomachad0 juliomachad0 self-assigned this Aug 25, 2024
@juliomachad0 juliomachad0 added the Enhancement New feature or request, including adjustments in current codes label Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (3a4c742) to head (7e33586).
Report is 43 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/motors/motor.py 89.18% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #676      +/-   ##
===========================================
- Coverage    75.87%   74.47%   -1.41%     
===========================================
  Files           85       89       +4     
  Lines        10085    10369     +284     
===========================================
+ Hits          7652     7722      +70     
- Misses        2433     2647     +214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR force-pushed the enh/motor_parameters_from_eng_files_by_default branch from 25441bd to 71204ec Compare September 8, 2024 22:30
@Gui-FernandesBR Gui-FernandesBR changed the title Enh/motor parameters from eng files by default ENH: Adds GenericMotor.load_from_eng_file() method Sep 8, 2024
@Gui-FernandesBR Gui-FernandesBR linked an issue Sep 8, 2024 that may be closed by this pull request
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid work, @juliomachad0 !! The new documentation page was really necessary and I believe it is going to help new users quite a lot!

@Gui-FernandesBR Gui-FernandesBR merged commit 251cf93 into develop Sep 8, 2024
5 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/motor_parameters_from_eng_files_by_default branch September 8, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

ENH: Use eng files to define additional motor parameters
2 participants