Add feoConfigEnabled bool to frontend spec for feo self service #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hyperkid123 do you mind taking a look? |
Hyperkid123
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Can we add a test for the chrome exception? This hardcoded exception might feel a bit strange to others. I want to make sure we have a check that would catch if someone removes it.
We can remove it once the migration is done and think about a better way of passing down the SSO URL, but until then its necessary.
Hyperkid123
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/RHCLOUD-35427
We have added a new optional flag called
feoConfigEnabledto the frontend spec that will allow for gradual consumption of all our tweaks to the operator by our tenant applications (as several of the tenant applications have very out of date modules and are missing the widgets, nav, etc. in their currentfrontend.yaml).I have updated our existing tests to account for this new flag and have added a new kuttl test that ensures when the flag is false - none of the modules/widgets/service tiles/etc are synced into the config map. This should allow chrome service to use the config if it is present - or fall back to the legacy flow with minimal logic.
We did need to make an exception for chrome frontend in the fed-modules evaluation logic to ensure that our SSO URL is always set.