Update navigation specs #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperkid123
force-pushed
the
navigation-spec
branch
3 times, most recently
from
86603bf to
f68b755
Compare
Hyperkid123
force-pushed
the
navigation-spec
branch
from
f68b755 to
a4c8ef6
Compare
I deployed a frontend to ephemeral and Chrome had the full set of navigation items (menus, etc) so that tells me it should be using what chrome-service is feeding it. |
|
OK, thanks @adamrdrew that is what I though was happening. Just want to be extra careful. |
Hyperkid123
force-pushed
the
navigation-spec
branch
from
a4c8ef6 to
22f5f10
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHCLOUD-33913
Changes
@psav @adamrdrew can you please confirm that not generating the navigation data will not totally break ephemeral envs? AFAIk it should be using the static files.