Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-28457] - Fix bucket issue #866

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[RHCLOUD-28457] - Fix bucket issue #866

merged 2 commits into from
Sep 21, 2023

Conversation

psav
Copy link
Collaborator

@psav psav commented Sep 21, 2023

The problem here is that secrets that were being "considered" as useful were able to set the hostname, so I made two tweaks to this.

  1. I moved the logic for setting the hostname so that it happens during the step where we validate the hostname. It's still not great because it means that you could get one or other of two hostnames, assuming that there are multiple secrets with differing endpoints.
  2. As part of this, I needed a way to send the endpoint through to that stage of the process, so I now added the ability for the endpoint to be exposed at the bucket level too. This means that buckets can have their own configuration of differing endpoints. It will be on applications to change to adopt this and I expect us to put out an ADR to deprecate the old approach very soon.

@psav psav force-pushed the psav/fix_bucket_issue branch from 0119a6e to d78a2d6 Compare September 21, 2023 10:05
@psav psav requested a review from adamrdrew September 21, 2023 10:16
@psav
Copy link
Collaborator Author

psav commented Sep 21, 2023

I also got rid of providers.StrPtr as we have that function in the rhc-osdk-utils now

@psav psav merged commit f290488 into master Sep 21, 2023
@psav psav deleted the psav/fix_bucket_issue branch February 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant