ROX-12152: added field for aws account number in central instance creation modal #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaudh
force-pushed
the
saif/aws-account-number
branch
from
8ee5092 to
f66825a
Compare
sachaudh
force-pushed
the
main
branch
11 times, most recently
from
3f0cf94 to
413d5a9
Compare
sachaudh
force-pushed
the
main
branch
4 times, most recently
from
142ba65 to
3a36164
Compare
sachaudh
force-pushed
the
saif/aws-account-number
branch
3 times, most recently
from
3066b49 to
8802d1a
Compare
sachaudh
changed the title
vjwilson
approved these changes
Oct 28, 2022
Comment on lines
+8
to
+9
| const { data } = await apiRequest.get(`/api/rhacs/v1/cloud_accounts`); | ||
| return data; |
There was a problem hiding this comment.
Looks like we're not leveraging the ability to see any error, or loading state.
There was a problem hiding this comment.
Yea that's true. I can resolve that separately
sachaudh
force-pushed
the
saif/aws-account-number
branch
from
8802d1a to
787adae
Compare
sachaudh
force-pushed
the
saif/aws-account-number
branch
from
787adae to
22859c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an extra form field in the instance creation form for the AWS account number. The form field will use a select component that let's you choose among your different cloud accounts.
Note: This PR is blocked until stackrox/acs-fleet-manager#517 is merged
Checklist (Definition of Done)
[ ] Unit and integration tests added[ ] Added test description underTest manual[ ] Documentation added if necessaryROX-12345: ...[ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Test manual
No Tests