Move Store API to work with identifiers, not graphs #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
files which are already done aka "sixed" not commented. files that still need modification are commented out.
the types variable became an iterable and was exhausted on 2nd check in py3
gromgull
force-pushed
the
identifier-as-context
branch
2 times, most recently
from
3db8ed3 to
c1f1a14
Compare
All add/remove methods now raise an Exception if passed a graph. The Graph API works on Graph objects and will pack/unpack as required.
gromgull
force-pushed
the
identifier-as-context
branch
from
c1f1a14 to
da6837e
Compare
|
I've rebased this onto the six_2to3 branch, and it passes the tests now. |
|
but the PR is for master 😅 |
|
one can change the base branch of a PR (edit on top), i'll do this... |
gromgull
force-pushed
the
six_2to3
branch
4 times, most recently
from
8f35c01 to
08e5cb8
Compare
|
I've assigned this to Milestone 6.0.0 and have marked it critical as this and graph IDing issues in general are well known annoyances and need a general solution (i.e. for Graph, ConjunctiveGraph, QuotedGraph??, Dataset and Store). This PR needs deduplicating with PR #845. |
|
This PR is long since obsolete so I'm closing |
ghost
mentioned this pull request
ghost
mentioned this pull request
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-time coming fix for #167.
There are two API layers in RDFLib, the Graph level and the Store level. The issue here is the handling of the fourth element of a quad, i.e. the context. Currently both layers use Graph objects to represent this fourth context element, but this leads to lots of trouble (see examples in #167).
This is an attempt to sort this out by having Graphs handled at the Graph API level, and have stores deal with the graph identifiers only. Hopefully, we can make this change transparent to end-users, but plugin developers will probably notice.
A list of changes:
This is not yet finished, but a PR helps me get an overview of what is left to fix.