Add some explanation and example to circuit library documentation #7354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
changed the title
Pull Request Test Coverage Report for Build 2190126833
💛 - Coveralls |
jakelishman
reviewed
Jan 25, 2022
mtreinish
added
the
stable backport potential
Co-authored-by: Julien Gacon <[email protected]>
Co-authored-by: Julien Gacon <[email protected]>
Co-authored-by: Julien Gacon <[email protected]>
Cryoris
reviewed
Apr 1, 2022
Co-authored-by: Julien Gacon <[email protected]>
|
I pushed a change to fix the docs build here. I had to remove the documenting of |
mtreinish
previously approved these changes
Apr 19, 2022
mtreinish
approved these changes
Apr 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
) * Add some explanation and example to circuit library * remove BooleanExpression * missing gates * standard and directives * title mod * generalized gates * boolean logic circuits * Basis Change Circuits and Arithmetic Circuits * section Amplitude Functions is duplicated. (maybe a bad merge in #5142?) * N-local and feature map * dup entry * Template circuits * ups * line too long * address #7354 (comment) * addressing #7354 (comment) * addressing #7354 (comment) * Update qiskit/circuit/library/__init__.py Co-authored-by: Jake Lishman <[email protected]> * import to address #7354 (comment) * Update qiskit/circuit/library/__init__.py Co-authored-by: Jake Lishman <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Jake Lishman <[email protected]> * addressing #7354 (comment) * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Apply suggestions from code review Co-authored-by: Matthew Treinish <[email protected]> * directives * pretty colors * undo changes in standard_gates/__init__.py * operations * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Julien Gacon <[email protected]> * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * example * Update qiskit/circuit/library/__init__.py Co-authored-by: Julien Gacon <[email protected]> * Fix Sphinx errors * Fix duplicate definitions and indentation * Fix typo Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit aee0dc4)
mergify bot
added a commit
that referenced
this pull request
Apr 19, 2022
) (#7955) * Add some explanation and example to circuit library * remove BooleanExpression * missing gates * standard and directives * title mod * generalized gates * boolean logic circuits * Basis Change Circuits and Arithmetic Circuits * section Amplitude Functions is duplicated. (maybe a bad merge in #5142?) * N-local and feature map * dup entry * Template circuits * ups * line too long * address #7354 (comment) * addressing #7354 (comment) * addressing #7354 (comment) * Update qiskit/circuit/library/__init__.py Co-authored-by: Jake Lishman <[email protected]> * import to address #7354 (comment) * Update qiskit/circuit/library/__init__.py Co-authored-by: Jake Lishman <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Jake Lishman <[email protected]> * addressing #7354 (comment) * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Apply suggestions from code review Co-authored-by: Matthew Treinish <[email protected]> * directives * pretty colors * undo changes in standard_gates/__init__.py * operations * Update qiskit/circuit/library/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/circuit/library/__init__.py Co-authored-by: Julien Gacon <[email protected]> * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * example * Update qiskit/circuit/library/__init__.py Co-authored-by: Julien Gacon <[email protected]> * Fix Sphinx errors * Fix duplicate definitions and indentation * Fix typo Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit aee0dc4) Co-authored-by: Luciano Bello <[email protected]>
26 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Qiskit/qiskit.org#2009 there is a redesign of the qiskit.org main page where one of aspect to highlight from Qiskit is the Circuit Library:
The
Learn more ->link in the Circuit Library box will point to https://qiskit.org/documentation/apidoc/circuit_library.html However, this page is a bit rough for the newcomer. This PR is an attempt to create a slightly more welcomed place, with a short explanation on what's the library and how to use it.Comments on how to do that are very much welcomed.
Details and comments
In addition to add a paragraph (mostly copied from https://qiskit.org/overview#circuits) and an example, I also included:
Standard Instructions