Always output PEP 600 platform tags #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
multiple-platform-tags
branch
from
a13b7b0 to
76f12a1
Compare
konstin
reviewed
May 6, 2021
| (Os::Macos, Arch::X86_64) => { | ||
| if universal2 { | ||
| "macosx_10_9_universal2".to_string() | ||
| "macosx_10_9_x86_64.macosx_11_0_arm64.macosx_10_9_universal2".to_string() |
There was a problem hiding this comment.
Same as #523 (comment): What extra information do we get through this that we don't get through macosx_10_9_universal2?
There was a problem hiding this comment.
Old version of pip which doesn't know about universal2 can still pick up this wheel.
There was a problem hiding this comment.
I'd prefer not to support old versions of pip and instead tell people to update their pip, given that the pip team doesn't support old versions and they print a yellow warning after every command run from an outdated version
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 22, 2021
https://build.opensuse.org/request/show/894986 by user mia + dimstar_suse - Update to 0.10.6 * Fix build with the “upload” feature disabled by ravenexp gh#PyO3/maturin#548 - Changes in 0.10.5: * Add manylinux_2_27 support gh#PyO3/maturin#521 * Add support for Windows arm64 target gh#PyO3/maturin#524 * Always output PEP 600 platform tags gh#PyO3/maturin#525 * Fix missing PyInit_<module_name> warning with Rust submodule gh#PyO3/maturin#528 * Better cross compiling support for PyO3 binding on Unix gh#PyO3/maturin#454 * Fix s390x architecture support gh#PyO3/maturin#530 * Fix auditwheel panic with s390x wheels gh#PyO3/maturin#532 * Support uploading heterogenous wheels by ravenexp gh#PyO3/maturin#544 * Warn about pyproject.toml missing maturin version constraint gh#PyO3/maturin#545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #523
https://www.python.org/dev/peps/pep-0425/#compressed-tag-sets