Fix bug for plugins using extend_default_ignore #1317
Merged
+407
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Black reformatted for me. I'll fix the others too |
sigmavirus24
force-pushed
the
fix-extend-default-ignore
branch
from
8fc745d to
4fe6f53
Compare
Since Flake8 3.0 we've had the ability for plugins to use `extend_default_ignore` to register codes they want disabled by default. This, however, was a permanent disabling unfortunately. Our code didn't have a way of understanding that this new set of `ignore` codes was actually the 'default' set for that run. Much like the extended_select_list, we now attach extended_ignore_list to be able to confidently determine if the ignore we get in the DecisionEngine is actually the Default Ignore list and what plugins what us to ignore by default. Refs PyCQA/pep8-naming#157
sigmavirus24
force-pushed
the
fix-extend-default-ignore
branch
from
7c89ee3 to
2bb0308
Compare
|
I'm not sure what your release plans are @asottile so I'll let you merge this |
|
I'm not planning to release for a while, but if this is important to you I can backport it to 3.9.x -- let me know! |
|
If you have docs around doing the backport I can also do it. I don't want to keep @ecolell hanging on that PR for too long. (Also knowing full well that pep8-naming will likely need a |
|
alrighty! released this as 3.9.1 I decided to run the release myself since there were significant conflicts |
|
Thank you! |
orviz
pushed a commit
to EOSC-synergy/mypipline.sqaaas
that referenced
this pull request
Jan 30, 2023
Reason: PyCQA/flake8#1317 Signed-off-by: Fredo Erxleben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Flake8 3.0 we've had the ability for plugins to use
extend_default_ignoreto register codes they want disabled by default.This, however, was a permanent disabling unfortunately. Our code didn't
have a way of understanding that this new set of
ignorecodes wasactually the 'default' set for that run. Much like the
extended_select_list, we now attach extended_ignore_list to be able to
confidently determine if the ignore we get in the DecisionEngine is
actually the Default Ignore list and what plugins what us to ignore by
default.
Refs PyCQA/pep8-naming#157
Extra entertainment for Anthony
