Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags similar to pydocstyle's --add-select/--add-ignore #1061

Closed
asottile opened this issue Apr 3, 2021 · 6 comments
Closed

Add flags similar to pydocstyle's --add-select/--add-ignore #1061

asottile opened this issue Apr 3, 2021 · 6 comments

Comments

@asottile
Copy link
Member

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Aug 19, 2017, 04:49

These flags are quite useful for folks who merely want to extend the existing select and ignore lists. That said, we've found in pydocstyle that the --add verb is confusing to some. I would suggest --extend-(select|ignore) instead.

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Aug 19, 2017, 04:49

cc @mfcabrera

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @scop on May 13, 2018, 14:08

mentioned in merge request !233

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @fwinkl on Jun 8, 2020, 07:22

mentioned in merge request !437

@MarcoGorelli
Copy link

Bit confused about this issue - doesn't flake8 already have extend-ignore?

@sigmavirus24
Copy link
Member

Yes but it doesn't have --extend-select

fwinkl added a commit to fwinkl/flake8 that referenced this issue Apr 10, 2021
Implement `--extend-select` command line argument following what was
done for `--extend-ignore` in !233. This option can be used to
selectively add individual codes without overriding the default list
entirely.

Addresses the remaining item of issue PyCQA#1061.
fwinkl added a commit to fwinkl/flake8 that referenced this issue Apr 11, 2021
Implement `--extend-select` command line argument following what was
done for `--extend-ignore` in !233. This option can be used to
selectively add individual codes without overriding the default list
entirely.

Addresses the remaining item of issue PyCQA#1061.
fwinkl added a commit to fwinkl/flake8 that referenced this issue Apr 11, 2021
Implement `--extend-select` command line argument following what was
done for `--extend-ignore` in !233. This option can be used to
selectively add individual codes without overriding the default list
entirely.

Addresses the remaining item of issue PyCQA#1061.
@asottile
Copy link
Member Author

via #1312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants