Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge #2

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Merge #2

merged 2 commits into from
Jan 29, 2020

Conversation

PrarabdhGarg
Copy link
Owner

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

PrarabdhGarg and others added 2 commits January 27, 2020 13:32
@PrarabdhGarg @rt4914
Fix #603 refactor play to lessons (#612)
ae5a0c4 
* Refactor play to lessons

As per the new mocks, the paly tab was renamed to lessons.
Hence, the entrire project was refactored, along with tests, to maintain
consistency with mocks.

Resolves #603

* Refactor remaining instances of play with lessons

Partly resolves #603

* Solve errors in the privious commit

* Additional Refactoring

* Delete Project.xml

* Minor refactoring

* Add files deleted prviously by mistake

* Update vcs.xml

* Update Project.xml

* Update Project.xml

* Update Project.xml
@nikitamarysolomanpvt
Fix part #530: topic play dashed line issue fix in pre lollipop devic…
3cf1964 
…es (#627)

* topic play dashed line issue fix in pre lollipop devices

* nit
@PrarabdhGarg PrarabdhGarg merged commit dc7bbbb into PrarabdhGarg:develop Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrarabdhGarg @nikitamarysolomanpvt