Add Y bounds check to InvokePrompt (Fixes #4790) #4791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Aligns behavior with that stated in issue #4790:
Since implicit callers (i.e. those not specifying a Y position) can't know where the prompt will get written, they can't guard against accidentally trying to update a prompt that's left the buffer. The only thing that can be done by anyone once the prompt has left the screen is to accept the line or abort.
Explicit callers passing a Y value in 'arg' at least know where they are trying to write the prompt so we can throw the exception and let them handle/recover (if desired).
PR Checklist
Microsoft Reviewers: Open in CodeFlow