Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Fixes #83: Fixes the selection bar movement in RTL. #84

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

bicknellr
Copy link
Contributor

The current implementation assumes that changing selection from a higher index tab to a lower index tab implies moving left on the screen (and lower to higher, right).

@bicknellr bicknellr force-pushed the bicknellr/issue-83 branch 2 times, most recently from dd728af to 547f75b Compare November 6, 2015 19:51
@cdata
Copy link
Contributor

cdata commented Nov 9, 2015

Ah, such a fun hack. I wonder if we could measure a property that has nothing to do with layout, and thus avoid potential layout recalculations (however small they might be). WDYT?

Also, @notwaldorf you should check this out, since it is a little on the crazy (crazy awesome?) side ;)

@bicknellr
Copy link
Contributor Author

Just as a heads up, I might be submitting a PR to add an RTL check in iron-menubar-behavior soonish and make use of it here instead. That one's going to use getComputedStyle since it only needs to happen once per keystroke and [dir=rtl] and friends would leave a few holes (:dir(rtl) isn't supported anywhere yet :( ).

@cdata
Copy link
Contributor

cdata commented Dec 1, 2015

Holding off on reviewing this until pending iron-menu-behavior PR shows up.

@bicknellr
Copy link
Contributor Author

self ping!

@bicknellr
Copy link
Contributor Author

(@cdata, PolymerElements/iron-menu-behavior#41 is the PR this is waiting on.)

@cdata
Copy link
Contributor

cdata commented Jan 23, 2016

Noting that this PR is transitively blocked on Polymer/polymer#2717

@bicknellr
Copy link
Contributor Author

@cdata Just rebased as all the blockers are in. I'm not sure how to test this though since it's an animation..

@cdata
Copy link
Contributor

cdata commented Feb 9, 2016

LGTM 👍

bicknellr added a commit that referenced this pull request Feb 9, 2016
Fixes #83: Fixes the selection bar movement in RTL.
@bicknellr bicknellr merged commit f0abeab into master Feb 9, 2016
@bicknellr bicknellr deleted the bicknellr/issue-83 branch February 9, 2016 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants