Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Use flex-basis of auto to fix IE #50

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Use flex-basis of auto to fix IE #50

merged 1 commit into from
Jan 27, 2016

Conversation

robrez
Copy link
Contributor

@robrez robrez commented Aug 14, 2015

Fixes #29

Tested on:

  • Chrome 44
  • FF39
  • IE11

@addyosmani
Copy link
Contributor

Thanks for working on this change, @robrez. Can we get this change verified against Edge too?

@robrez
Copy link
Contributor Author

robrez commented Sep 1, 2015

Please advise...

I don't have access to a windows10 machine and I'm not sure how/if I can setup wct to test against edge when edge isn't locally installed.

The best I've been able to do is run IE11 w/ emulation set to edge. Everything ...looks... okay in emulation mode.

I did try using Remote Test IE but the remote desktop session isn't working - maybe related to my workplace firewall. I'll try this again later from home.

@addyosmani
Copy link
Contributor

No worries. We'll get it tested on Edge and report back.

@syntax42
Copy link

Status for this fix?

@robrez
Copy link
Contributor Author

robrez commented Jan 27, 2016

Rebased this PR today

  • Top image: Before patch, tabs have 0 width
  • Bottom image: After patch, tab sizing and behavior matches pre-patched sizing and behavior from chrome
    tabspatch

@robrez robrez mentioned this pull request Jan 27, 2016
@bicknellr
Copy link
Contributor

Thanks for updating this!

@bicknellr
Copy link
Contributor

I've tried it out on the latest versions of {Windows, OS X} × {Edge, IE, Chrome, Firefox, Safari} and it looks good.

bicknellr added a commit that referenced this pull request Jan 27, 2016
Use flex-basis of auto to fix IE
@bicknellr bicknellr merged commit b125fbd into PolymerElements:master Jan 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants