Momentum drawer #55
Momentum drawer #55
Conversation
| } | ||
| }, | ||
|
|
||
| _trackHandler: function(event) { | ||
| if (!this.persistent) { | ||
| // Disable user selection. | ||
| event.preventDefault(); |
There was a problem hiding this comment.
I don't think calling preventDefault on track event can prevent selection. Usually you will need to call peventDefault on down (or mousedown) event.
There was a problem hiding this comment.
This seems to work at least when dragging the drawer horizontally on desktop (can still select when dragging vertically). I don't want to disable user selection altogether, but I found that the selection is causing a repaint when I close the drawer on desktop.
I'll update the comment above to specify that this is for desktop.
| this._startTimeStamp = performance.now(); | ||
|
|
||
| // Track handler takes precedence over scrim tap handler. | ||
| this.cancelDebouncer('_scrimTapHandler'); |
There was a problem hiding this comment.
I believe this might not be necessary, same as line 263. The track event should automatically prevent tap.
There was a problem hiding this comment.
It does not, at least on Chrome mobile :(
There was a problem hiding this comment.
@blasten is right. The track event should automatically prevent tap. I did a simple test on Chrome mobile and it seems to do what I expected.
There was a problem hiding this comment.
Yup, I could reproduce what @keanulee was seeing. Sounds like a bug in polymer gestures.
| track: '_trackHandler' | ||
| track: '_track', | ||
| transitionEnd: '_transitionEnd', | ||
| webkitTransitionEnd: '_transitionEnd' |
There was a problem hiding this comment.
don't think we need webkitTransitionEnd
There was a problem hiding this comment.
Needed for Safari :(
There was a problem hiding this comment.
I think you need to lowercase the event name transitionend and it should work on Chrome, Safari and other supported browsers.
transitionend: '_transitionEnd'
There was a problem hiding this comment.
Ah, you're right. Thanks.
|
LGTM |
Some unrelated tests are flaking, but ready to merge now.
@frankiefu @blasten