Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove importHref from 3.0 #5223

Merged
merged 1 commit into from
May 9, 2018
Merged

Remove importHref from 3.0 #5223

merged 1 commit into from
May 9, 2018

Conversation

kevinpschaaf
Copy link
Member

Remove importHref, as HTML Import support has been removed from 3.0.

justinfagnani
justinfagnani approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this update the change log? Speaking of, we don't have a 3.0 entry in the change log 😮

@dfreedm dfreedm merged commit 09958f9 into 3.x May 9, 2018
@dfreedm dfreedm deleted the 3.x-remove-imporHref branch May 9, 2018 18:27
@beauwest
Copy link

beauwest commented Jun 7, 2018

The Polymer 3.0 API Reference still includes the page and information for import-href: https://www.polymer-project.org/3.0/docs/api/utils/import-href

It threw me off for a while during my upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@dfreedm dfreedm Awaiting requested review from dfreedm

@sorvell sorvell Awaiting requested review from sorvell

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.