Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten a type. Bump TS generator version. Format Travis type error. #5099

Merged
merged 4 commits into from
Feb 7, 2018

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Feb 7, 2018

  • Make EventApi.path's EventTarget type non-nullable.
  • Bump TypeScript generator version.
  • Make Travis update-types failure style the same as the elements.

@aomarks aomarks requested a review from dfreedm February 7, 2018 06:37
@aomarks aomarks changed the title Misc typescript Tighten a type. Bump TS generator version. Format Travis type error. Feb 7, 2018
@aomarks
Copy link
Member Author

aomarks commented Feb 7, 2018

Hmm, Travis is failing because package-lock.json changed. I guess npm install can do that? Not sure why this never came up before though. I'm doing it through npm run update-types instead of gulp update-types now, but it should be the exact same thing.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 7, 2018
@TimvdLippe
Copy link
Contributor

@aomarks I have regenerated the lock file with npm 5.6.0. Not sure why your original install did not fully "lock" the lockfile.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Congrats on the stable release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants