-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text nodes are not distributed to default slot #4109
Comments
In this case default slot gets shimmed to |
Unfortunately my PR fixes shady only. How would I go about resolving this failing test in shadow? |
Unfortunately we can't make a shady-only fix, so we can't take @TomK's solution. I think we're going to resolve this by rolling back the automatic Instead, we'll just convert catch-all |
Any update on this? It's a blocker for deploying 1.7 for us. |
@ChadKillingsworth you should be able to convert all your |
We can make that work for now. Thanks. |
I think we have a workable strategy now. Basically, there is no good way to transform this <slot></slot>
<div>Middle?</div>
<slot name="specific"></slot> and keep text nodes working. Instead, it will have to be up to the user to have the "fallback" slot last in the order, and if necessary, use flexbox or transform to move the visual DOM into the desired position. Here's an example using flexbox ordering to simulate the above DOM: http://jsbin.com/kugudot/2/edit?html,output |
When entering text nodes in the host element, they are not distributed to the default slot.
Live Demo
http://codepen.io/oridan/pen/rrgvQY?editors=1000
Expected Results
The live demo should show two rows as follows:
[Icon] item 1
[Icon] item 2
Actual Results
I see just two icons:
[Icon]
[Icon]
Browsers Affected
Versions
The text was updated successfully, but these errors were encountered: