Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment timing subtly differs under Shadow and Shady DOM #3637

Closed
sorvell opened this issue May 6, 2016 · 2 comments
Closed

Attachment timing subtly differs under Shadow and Shady DOM #3637

sorvell opened this issue May 6, 2016 · 2 comments

Comments

@sorvell
Copy link
Contributor

sorvell commented May 6, 2016

When an element is registered asynchronously, under Shady DOM attached for hosted elements fires for all nested elements after all nested element observers have run. Under Shadow DOM, attached fires after each nested element's observers run. In general, attachment state is not something that should be relied on in observers (due to the fact that an element may be created outside of dom and attached later); however, the inconsistency between Shady and Shadow DOM is a subtle difference that should be eliminated if possible. Polymer should normalize to the Shady attached behavior.

Behavior under Shady DOM: http://jsbin.com/nudaqozari/1/edit?html,console,output.

Behavior under Shadow DOM: http://jsbin.com/bagoyihoye/edit?html,console,output.

@sorvell sorvell self-assigned this May 6, 2016
sorvell pushed a commit that referenced this issue May 6, 2016
@dfreedm
Copy link
Member

dfreedm commented Jun 7, 2016

This timing change breaks the contract that local dom is distributed before ready callback. If we still want this change, it will have to keep that contract.

dfreedm added a commit that referenced this issue Jun 7, 2016
…dow DOM under native Custom Elements."

This reverts commit 9d272e0.
@dfreedm dfreedm closed this as completed in 6c0acef Jun 7, 2016
@sorvell sorvell reopened this Jun 17, 2016
@sorvell sorvell mentioned this issue Jun 17, 2016
@tjsavage tjsavage added the 1.x label Sep 8, 2016
@sorvell
Copy link
Contributor Author

sorvell commented Dec 12, 2017

The original links are now out of date. Here are updated examples that show the issue persists in Polymer 1.x:

This issue has been fixed in Polymer 2.x

Closing this issue since it has been corrected in Polymer 2.x and is too difficult to address without breaking changes in 1.x.

@sorvell sorvell closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants