Merge pull request #4988 from limonte/fix/listen-slots

FlattenedNodesObserver: do not fail on node without children
Polymer · Dec 20, 2017 · b7bd545 · b7bd545
2 parents ee1d71f + 09bb6cd
commit b7bd545
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/utils/flattened-nodes-observer.html b/lib/utils/flattened-nodes-observer.html
@@ -143,7 +143,7 @@
     connect() {
       if (isSlot(this._target)) {
         this._listenSlots([this._target]);
-      } else {
+      } else if (this._target.children) {
         this._listenSlots(this._target.children);
         if (window.ShadyDOM) {
           this._shadyChildrenObserver =
@@ -172,7 +172,7 @@
     disconnect() {
       if (isSlot(this._target)) {
         this._unlistenSlots([this._target]);
-      } else {
+      } else if (this._target.children) {
         this._unlistenSlots(this._target.children);
         if (window.ShadyDOM && this._shadyChildrenObserver) {
           ShadyDOM.unobserveChildren(this._shadyChildrenObserver);

diff --git a/test/unit/flattened-nodes-observer.html b/test/unit/flattened-nodes-observer.html
@@ -1039,6 +1039,16 @@
       document.body.removeChild(host);
     });
 
+    test('should not fail on node without children', function() {
+      var recorded;
+      var el = document;
+      var observer = new Polymer.FlattenedNodesObserver(el, function(info) {
+        recorded = info;
+      });
+      assert.equal(recorded, null);
+      observer.disconnect();
+    });
+
   });
 
 </script>