Make behaviors array unique

src/micro/behaviors.html

@@ -65,16 +65,21 @@
     },
 
     _desugarSomeBehaviors: function(behaviors) {
+      var behaviorSet = [];
       // iteration 1
       behaviors = this._flattenBehaviorsList(behaviors);
       // iteration 2
       // traverse the behaviors in _reverse_ order (youngest first) because
       // `_mixinBehavior` has _first property wins_ behavior, this is done
       // to optimize # of calls to `_copyOwnProperty`
       for (var i=behaviors.length-1; i>=0; i--) {
-        this._mixinBehavior(behaviors[i]);
+        var b = behaviors[i];
+        if (behaviorSet.indexOf(b) === -1) {
+          this._mixinBehavior(b);
+          behaviorSet.unshift(b);
+        }
       }
-      return behaviors;
+      return behaviorSet;
     },
 
     _flattenBehaviorsList: function(behaviors) {
@@ -141,7 +146,7 @@
 
   });
 
-  // special properties on behaviors are not mixed in and are instead 
+  // special properties on behaviors are not mixed in and are instead
   // either processed specially (e.g. listeners, properties) or available
   // for calling via doBehavior (e.g. created, ready)
   Polymer.Base._behaviorProperties = {

test/unit/behaviors.html

@@ -133,21 +133,33 @@
       assert.match(message, /behavior is null/);
       warned = true;
     };
-
     Polymer({
-
+      is: 'behavior-null',
       behaviors: [
         null
-      ],
-
-      is: 'behavior-null'
-
+      ]
     });
-
     assert.equal(warned, true, 'Null behaviour should generate warning');
     Polymer.Base._warn = oldWarn;
   });
 
+  test('behavior array is unique', function() {
+    Polymer({
+      is: 'behavior-unique',
+      behaviors: [Polymer.BehaviorA, Polymer.BehaviorA]
+    });
+    assert.equal(document.createElement('behavior-unique').behaviors.length, 1);
+  });
+
+  test('duplicate behaviors keep last behavior', function() {
+    Polymer({
+      is: 'behavior-unique-last-behavior',
+      behaviors: [[Polymer.BehaviorA, Polymer.BehaviorB], Polymer.BehaviorA]
+    });
+    var behaviors = document.createElement('behavior-unique-last-behavior').behaviors;
+    assert.deepEqual(behaviors, [Polymer.BehaviorB, Polymer.BehaviorA]);
+  });
+
 });