Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

[#916] Added valueattr to paper-tabs example #917

Closed
wants to merge 1 commit into from
Closed

[#916] Added valueattr to paper-tabs example #917

wants to merge 1 commit into from

Conversation

Nevraeka
Copy link

@Nevraeka Nevraeka commented Mar 2, 2015

simple attribute add

@arthurevans
Copy link

This is a little confusing, but valueattr actually defaults to 'name', so this is unnecessary. See valueattr docs here:

https://www.polymer-project.org/docs/elements/core-elements.html#core-selector

@robdodson
Copy link
Contributor

@arthurevans hm that is confusing, especially for a new user. Maybe we can modify the text a bit.

ex: "selected="all" chooses the first tab with a matching name attribute as the initially selected tab."

@Nevraeka
Copy link
Author

Nevraeka commented Mar 2, 2015

I see what you mean

@Nevraeka
Copy link
Author

Nevraeka commented Mar 2, 2015

:+1 @robdodson . I assume you are referring to the descriptive text, and not the code example. :)

@arthurevans
Copy link

Sounds good. Ironically, we used to have the valueattr attribute here, but
a prior PR removed it as unnecessary.

Will file a text PR this afternoon (and see if I can clarify the somewhat
vague docs for x-selector.
On Mar 2, 2015 11:22 AM, "Rob Dodson" [email protected] wrote:

@arthurevans https://github.com/arthurevans hm that is confusing,
especially for a new user. Maybe we can modify the text a bit.

ex: "selected="all" chooses the first tab with a matching name attribute
as the initially selected tab."


Reply to this email directly or view it on GitHub
#917 (comment).

@Nevraeka
Copy link
Author

Nevraeka commented Mar 2, 2015

Thanks @arthurevans . Should I cancel this PR then?

@robdodson
Copy link
Contributor

Yeah I'm referring to the descriptive text in the tutorial

ebidel added a commit that referenced this pull request Apr 6, 2015
@ebidel
Copy link
Contributor

ebidel commented Apr 6, 2015

Cleared up in 78a0acb

@ebidel ebidel closed this Apr 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants