Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update ashpd to 0.11 #240

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

torokati44
Copy link
Contributor

Continuing #220...
The dependency deduplication is blocked on a new release of ppv-lite86 (cryptocorrosion/cryptocorrosion#83 (comment)) (for zerocopy and zerocopy-derive), and on tokio-rs/mio#1836, I think (for wasi).

@valadaptive
Copy link
Contributor

This appears to be necessary for things to build now, dependency duplication or not--bilelmoussaoui/ashpd#264 means the current version of rfd no longer builds.

@torokati44
Copy link
Contributor Author

A new version of ppv-lite86 just got released, so the only blocker remaining is tokio-rs/mio#1836.

@torokati44 torokati44 marked this pull request as ready for review March 10, 2025 13:05
@torokati44
Copy link
Contributor Author

Oh, it turns out, the wasi duplication is only apparent when looking at Cargo.lock by eye, but in reality none of the target triples actually pull in both 0.11 and 0.13...?! I guess this crate only makes sense for WASM targets, and only wasm32-unknown-unknown of those is checked by cargo-deny.
So, is it possible that this is mergeable after all? 👀

@PolyMeilex
Copy link
Owner

Yep, this is totally fine, thanks!

@PolyMeilex PolyMeilex merged commit 24842c4 into PolyMeilex:master Mar 10, 2025
13 checks passed
@torokati44
Copy link
Contributor Author

Do you think we could get a release on crates.io with this in it sometime soon? 🙏 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants