Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu to Switch workspace to branch #98

Merged
merged 12 commits into from
Nov 23, 2023

Conversation

SRombautsU
Copy link

@SRombautsU SRombautsU commented Nov 20, 2023

image

  • Minor rename and ordering of source control callbacks
  • Fix boolean logic to check if the source control provider is enabled and available
  • Improvement of RefreshStatus to replace OnStart/OnEndSourceControlOperation()
  • Don't display the number of branches, it's confusing and doesn't bring any value
  • Add a context menu -> Switch workspace to branch
  • Move duplicated notification methods into a new FNotification class
  • Move SaveDirtyPackages() and ListAllPackages() from FPlasticSourceControlMenu to PackageUtils
  • New PlasticSourceControlUtils RunSwitchToBranch()
  • New SwitchToBranch operation and Worker
  • Execute the switch operation from the context menu, asynchronously, with an ongoing notification while it runs
  • ReloadPackages & current map at the end of the switch branch operation

@SRombautsU SRombautsU self-assigned this Nov 20, 2023
@SRombautsU SRombautsU force-pushed the 1003833-switch-workspace-to-branch branch 7 times, most recently from d5cd9ed to 120e9cb Compare November 21, 2023 08:59
@SRombautsU SRombautsU force-pushed the 1003833-switch-workspace-to-branch branch from 120e9cb to 2b19190 Compare November 21, 2023 10:49
@SRombautsU SRombautsU marked this pull request as ready for review November 21, 2023 11:25
…ration()

The RefreshStatus is overriden by the TickRefreshStatus on each tick anyway
it was only some forgotten debug code
Run cm switch br:/name --xml
Parse XML result like the cm update
Execute asynchronously, with an ongoing notification while it runs
Ask for a full refresh of the list of branches at the end of the operation, so it will also refresh the UI
@SRombautsU SRombautsU force-pushed the 1003833-switch-workspace-to-branch branch from 49fc27c to 0b873e8 Compare November 21, 2023 11:52
@juliomaqueda juliomaqueda self-requested a review November 22, 2023 12:42
@juliomaqueda juliomaqueda merged commit d8fa5b5 into master Nov 23, 2023
@juliomaqueda juliomaqueda deleted the 1003833-switch-workspace-to-branch branch November 23, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants