forked from SRombauts/UEPlasticPlugin
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a context menu to Switch workspace to branch #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
commented
Nov 20, 2023
•
edited
Loading
edited
- Minor rename and ordering of source control callbacks
- Fix boolean logic to check if the source control provider is enabled and available
- Improvement of RefreshStatus to replace OnStart/OnEndSourceControlOperation()
- Don't display the number of branches, it's confusing and doesn't bring any value
- Add a context menu -> Switch workspace to branch
- Move duplicated notification methods into a new FNotification class
- Move SaveDirtyPackages() and ListAllPackages() from FPlasticSourceControlMenu to PackageUtils
- New PlasticSourceControlUtils RunSwitchToBranch()
- New SwitchToBranch operation and Worker
- Execute the switch operation from the context menu, asynchronously, with an ongoing notification while it runs
- ReloadPackages & current map at the end of the switch branch operation
d5cd9ed
to
120e9cb
Compare
120e9cb
to
2b19190
Compare
…ration() The RefreshStatus is overriden by the TickRefreshStatus on each tick anyway
it was only some forgotten debug code
…trolMenu to PackageUtils
Run cm switch br:/name --xml Parse XML result like the cm update
Execute asynchronously, with an ongoing notification while it runs Ask for a full refresh of the list of branches at the end of the operation, so it will also refresh the UI
49fc27c
to
0b873e8
Compare
juliomaqueda
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.