Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Update Workspace status on Editor startup" #96

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

mig42
Copy link

@mig42 mig42 commented Oct 26, 2023

Fix "Update Workspace status on Editor startup"

Description

@SRombautsU analysed the issue.

The option to "Run an asynchronous Update Status at Editor startup (can be slow)." doesn't work anymore since we made a fix to run the initial connection much earlier at Init() of the plugin. Since then, in daily work, the connection has already been established before the first call to the "Connect" operation by the Unreal Editor.

As a consequence, FPlasticConnectWorker::Execute() is never called with IsAvailable() being false.

This regression has been introduced by Commit 60dffefd by Sébastien Rombauts, 05/12/2022 04:05 PM

Fix FPlasticSourceControlProvider::Init() to respect bForceConnection

Execute a 'checkconnection' command to set bServerAvailable based on the connectivity of the server

In pull request #29 - Fix connection at init for commandlets.

Steps to reproduce

  1. From the global source control menu, open "Change Revision Control Settings"
  2. Enable Update workspace Status at Editor startup
  3. Close the Unreal Editor properly to ensure the flag is saved
  4. Restart Unreal Editor and check the notifications and the logs

Expected behaviour

  • A global status operation is called on the whole Content/ directory a Editor startup from the "connect" operation

Actual behaviour

  • There is no such an "status" command visible in the logs

@SRombautsU SRombautsU self-requested a review October 26, 2023 16:18
mig42 added 3 commits October 27, 2023 08:47
Replace angles with quotes and place it in the appropriate position.

Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
The point of the initial status warmup is to ensure that the changes cache is ready. So, instead of checking the status of controlled items only, we need to fully check the workspace status.

Signed-off-by: Miguel González <[email protected]>
@mig42 mig42 marked this pull request as ready for review October 27, 2023 06:53
Copy link

@SRombautsU SRombautsU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@SRombautsU SRombautsU merged commit b93f0af into master Oct 30, 2023
@SRombautsU SRombautsU deleted the miguel/fix-update-on-startup branch October 30, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants