forked from SRombauts/UEPlasticPlugin
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context Admin menu to Release or Remove a Lock from the Content Browser #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
commented
Sep 27, 2023
•
edited
Loading
edited
- Simplification of RunListSmartLocks() and cleanup of variables
- FSmartLockInfoParser now also retrieve the Lock's ItemId and Date in order to unlock them
- Implement a new helper FPlasticSourceControlModule::IsLoaded()
- Implement a new PackageUtils AssetDateToFileNames()
- Add the Unlock Operation and associated Worker to Release or Remove Locks
- Implement a new FPlasticSourceControlProvider::GetCloudOrganization() to use it in multiple places in the Menu
- Release/Remove Locks from a new asset context admin submenu
- Adjusted UI implementation for UE4.27 and UE5.0 as the UI menu system was slightly different in before UE5.1 (no SelectedAssets in Context)
The underlying cm lock list command already uses the proper server, no need to use --server= Removal of unused RevisionHead
69efd52
to
f76d4bf
Compare
…order to unlock them
…ock(s) on file(s)
… to use it in multiple places in the Menu
f76d4bf
to
d7910c3
Compare
9fd76f2
to
b57abf2
Compare
Without a LockedId we cannot call the modern variant of "cm lock unlock" command not having a LockedId means the UVCS installed version is too old
danielhompanera
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.