Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Admin menu to Release or Remove a Lock from the Content Browser #92

Merged
merged 9 commits into from
Oct 5, 2023

Conversation

SRombautsU
Copy link

@SRombautsU SRombautsU commented Sep 27, 2023

  • Simplification of RunListSmartLocks() and cleanup of variables
  • FSmartLockInfoParser now also retrieve the Lock's ItemId and Date in order to unlock them
  • Implement a new helper FPlasticSourceControlModule::IsLoaded()
  • Implement a new PackageUtils AssetDateToFileNames()
  • Add the Unlock Operation and associated Worker to Release or Remove Locks
  • Implement a new FPlasticSourceControlProvider::GetCloudOrganization() to use it in multiple places in the Menu
  • Release/Remove Locks from a new asset context admin submenu
  • Adjusted UI implementation for UE4.27 and UE5.0 as the UI menu system was slightly different in before UE5.1 (no SelectedAssets in Context)

The underlying cm lock list command already uses the proper server, no need to use --server=

Removal of unused RevisionHead
@SRombautsU SRombautsU self-assigned this Sep 27, 2023
@SRombautsU SRombautsU force-pushed the 1003723-release-or-remove-a-lock branch 2 times, most recently from 69efd52 to f76d4bf Compare September 27, 2023 10:29
@SRombautsU SRombautsU force-pushed the 1003723-release-or-remove-a-lock branch from f76d4bf to d7910c3 Compare September 27, 2023 10:31
@SRombautsU SRombautsU marked this pull request as ready for review September 27, 2023 10:48
@SRombautsU SRombautsU force-pushed the 1003723-release-or-remove-a-lock branch from 9fd76f2 to b57abf2 Compare September 27, 2023 13:37
Without a LockedId we cannot call the modern variant of "cm lock unlock" command
not having a LockedId means the UVCS installed version is too old
@danielhompanera danielhompanera self-requested a review October 3, 2023 13:14
Copy link

@danielhompanera danielhompanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! LGTM

@danielhompanera danielhompanera merged commit 739b59c into master Oct 5, 2023
@danielhompanera danielhompanera deleted the 1003723-release-or-remove-a-lock branch October 5, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants