Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Smart Locks information in the Content Browser #134 #91

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

SRombautsU
Copy link

@SRombautsU SRombautsU commented Sep 19, 2023

  • Add version 11.0.16.8101 as the one Introducing Smart Locks (2023/07/06)
  • Implementation of RunListSmartLocks() and the associated FSmartLockInfoParser
  • Update RunFileinfo() and FPlasticFileinfoParser to fetch the ServerPath
  • Call the new RunListSmartLocks() from ParseFileinfoResults() and use it for SmartLocks information
  • New IsRetainedInOtherBranch() used to display "Retained" locks overlay Icon and Tooltip
  • Hack IsCheckedOutInOtherBranch() to work as IsRetainedInOtherBranch()

@SRombautsU SRombautsU self-assigned this Sep 19, 2023
@SRombautsU SRombautsU force-pushed the 1003838-smartlocks-decorators branch from 04dca96 to d74cb8e Compare September 19, 2023 15:32
@SRombautsU SRombautsU force-pushed the 1003838-smartlocks-decorators branch 3 times, most recently from 907f422 to d23c0a0 Compare September 19, 2023 19:31
Retrieve additional information coming from SmartLocks: branch name and "Retained" lock status
Using our own custom IsRetainedInOtherBranch() method isn't enough: the plugin needs to use existing Engine hooks to display icons, so its taking advantage of the otherwise unused IsCheckedOutInOtherBranch()
@SRombautsU SRombautsU force-pushed the 1003838-smartlocks-decorators branch from d23c0a0 to 58dbd53 Compare September 20, 2023 06:34
@SRombautsU SRombautsU marked this pull request as ready for review September 20, 2023 06:39
@juliomaqueda juliomaqueda self-requested a review September 20, 2023 09:47
@juliomaqueda juliomaqueda merged commit e5e8ae5 into master Sep 20, 2023
@juliomaqueda juliomaqueda deleted the 1003838-smartlocks-decorators branch September 20, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants