Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the 3 way merge tool not showing the Source (Remote) revision… #57

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

SRombautsU
Copy link

… of the file, instead showing twice the Target (Local) revision.

In case of a merge conflict, we need to put the tip of the "remote branch" on top of the history; it means that we need to keep this revision in the list of revision even if this is a revision higher than the head/changeset

@SRombautsU SRombautsU added the bug label Dec 19, 2022
@SRombautsU SRombautsU self-assigned this Dec 19, 2022
… of the file, instead showing twice the Target (Local) revision.

In case of a merge conflict, we need to put the tip of the "source (remote)" branch at the top of the history (index 0);
it means that we need to keep this revision in the list of revision even if this is a revision higher than the head/changeset

You can think of this as the simplest way to display the "merge in progress" in a 1D graph of the current branch (target)
(as a future potential changeset, the same way we display the local changes yet to be submitted on the current branch)
We need to extract the file name without the " (Merge from <CS>)" postfix;

PS C:\Workspace\UE5PlasticPluginDev> cm status Content --compact
cs:139@rep:UE5PlasticPluginDev@repserver:test@cloud

Modified items (CH = changed, CO = checked-out, CP = copied (new), RP = replaced)
 CO Content\NewFolder\BP_CheckedOut.uasset (Merge from 140)
@SRombautsU SRombautsU force-pushed the 1002622-fix-conflict-3-way-merge branch from bd39167 to 05a6ab3 Compare December 19, 2022 10:30
Copy link

@danielhompanera danielhompanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielhompanera danielhompanera merged commit 17794b6 into master Dec 20, 2022
@danielhompanera danielhompanera deleted the 1002622-fix-conflict-3-way-merge branch December 20, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants