forked from SRombauts/UEPlasticPlugin
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of the new --workingbranch to filter multiple destination branches #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67de8d3
to
965de6a
Compare
…h to filter multiple destination branches Only retrieve Locks that are sharing the same destination branch as the current branch
965de6a
to
740d279
Compare
…o use it in the Menu as well
…llDestBranches Retrieve locks for all destination branches, or restrict them to only those applying to the working branch
1. locks applying to the working branch only, to be displayed as status overlay icons in the content browser 2. locks for all destination branches, to show in the View Locks list
…in the context menu Get only the locks applying to the working branch and for the specified files.
…rWorkingBranch() to handle Lock Refs directly instead of dealing with FAssetData (basically file path) It means that the "Unlock" operation is now always called with Locks and not solely with Files, which simplifies it
68d841c
to
b553be4
Compare
…ays trigger a refresh of the List of Locks It's needed since when removing the Lock of a Checked Out asset there is actually no change in local status as the asset remains Checked Out!
juliomaqueda
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the Content Browser, filter the list of Locks to only display those applying to the same destination branch as the current branch (eg all locks targeting /main/release if currently working on /main/release/hotfixXXX)
On the other hand, the View Locks windows still display locks for all destination branches.
This require to different calls to cm lock list, and as such, two different caches for their different results.