Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux-related stdio fixes and update version #22

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Linux-related stdio fixes and update version #22

merged 1 commit into from
Feb 19, 2025

Conversation

PederHP
Copy link
Owner

@PederHP PederHP commented Feb 19, 2025

Pull Request

Description of Changes

  • Modified GetCommand to return OS-specific commands and changed return type to string?.
  • Improved InitializeCommand for better command initialization and logging.
  • Cleaned up using directives in Log.cs and SseClientTransport.cs.
  • Updated CreateNoWindow property in StdioClientTransport to be OS-dependent.
  • Bumped version number in mcpdotnet.csproj to 1.0.1.1.

Related Issue(s)

  • Fixes Linux client issues related to hardcoded shell wrapping of MCP servers using stdio transport

Testing Done

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

- Modified `GetCommand` to return OS-specific commands and changed return type to `string?`.
- Improved `InitializeCommand` for better command initialization and logging.
- Cleaned up using directives in `Log.cs` and `SseClientTransport.cs`.
- Updated `CreateNoWindow` property in `StdioClientTransport` to be OS-dependent.
- Bumped version number in `mcpdotnet.csproj` to 1.0.1.1.
@PederHP PederHP merged commit 502a09d into main Feb 19, 2025
@PederHP PederHP deleted the linux_stdio branch February 19, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant