Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard terminal obs by default, set reset reward #1

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Discard terminal obs by default, set reset reward #1

merged 3 commits into from
Jan 18, 2023

Conversation

dfilan
Copy link
Collaborator

@dfilan dfilan commented Jan 17, 2023

As it says on the tin.

@dfilan
Copy link
Collaborator Author

dfilan commented Jan 17, 2023

Gimme a min to run code checks

@dfilan dfilan requested a review from PavelCz January 17, 2023 22:10
@dfilan
Copy link
Collaborator Author

dfilan commented Jan 17, 2023

(I think the base code has a type error but decided not to deal with that here)

PavelCz
PavelCz approved these changes Jan 18, 2023
View reviewed changes
Copy link
Owner

@PavelCz PavelCz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PavelCz PavelCz merged commit f6ffcf5 into autoreset-terminal-obs Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelCz PavelCz PavelCz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfilan @PavelCz