Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functions instead of the intrinsics #617

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

gbaraldi
Copy link
Contributor

Intrinsics aren't promised to always be there, specially because some functions can be moved from intrinsics to functions.
See JuliaLang/julia#48685. The functions are probably more stable so use them by default

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #617 (6bf3b43) into master (18e1ed1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6bf3b43 differs from pull request most recent head 8532249. Consider uploading reports for the commit 8532249 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files          16       16           
  Lines        1489     1489           
=======================================
  Hits         1326     1326           
  Misses        163      163           
Impacted Files Coverage Δ
src/fastmath.jl 87.14% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@giordano giordano merged commit 60860d3 into PainterQubits:master Feb 16, 2023
@gbaraldi gbaraldi deleted the remove-intrinsics branch February 16, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants