Fix * for numbers with non-commutative multiplication
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 89.03% 87.95% -1.09%
==========================================
Files 16 16
Lines 1487 1453 -34
==========================================
- Hits 1324 1278 -46
- Misses 163 175 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sostock
force-pushed
the
noncommutative_mult
branch
from
aeb0a5e to
2f2533a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607.
There are other methods of
*,/, and//that switch the order of a multiplication, but they only apply to types likeUnits,Real,Level, orGain, for which multiplication is actually commutative.