Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement traits correctly #407

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Implement traits correctly #407

merged 2 commits into from
Jan 15, 2021

Conversation

sostock
Copy link
Collaborator

@sostock sostock commented Dec 20, 2020

The old implementation works correctly for Quantity{T} when T is a number type defined in Base, but not when T is defined elsewhere and has a custom implementation of these traits.

@codecov-io
Copy link

codecov-io commented Dec 20, 2020

Codecov Report

Merging #407 (0d50f2a) into master (b32de8d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   80.41%   80.48%   +0.06%     
==========================================
  Files          15       15              
  Lines        1195     1194       -1     
==========================================
  Hits          961      961              
+ Misses        234      233       -1     
Impacted Files Coverage Δ
src/range.jl 79.54% <100.00%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32de8d...0d50f2a. Read the comment docs.

@giordano
Copy link
Collaborator

Any test relevant for this change?

@sostock
Copy link
Collaborator Author

sostock commented Jan 12, 2021

Any test relevant for this change?

I’ll add one.

@sostock
Copy link
Collaborator Author

sostock commented Jan 13, 2021

I added tests, utilizing the Num type already defined in the test suite.

@giordano giordano merged commit 9126cc5 into PainterQubits:master Jan 15, 2021
@sostock sostock deleted the traits branch January 15, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants