Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding with digits/sigdigits #308

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

sostock
Copy link
Collaborator

@sostock sostock commented Feb 21, 2020

Fixes #307

This PR makes round(u::Units, x::Quantity, digits/sigdigits=...) return a quantity based on a floating-point number (as does rounding with digits/sigdigits for unitless numbers).

@codecov-io
Copy link

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files          15       15           
  Lines        1129     1129           
=======================================
  Hits          919      919           
  Misses        210      210
Impacted Files Coverage Δ
src/quantities.jl 93.04% <100%> (ø) ⬆️
src/pkgdefaults.jl 30.61% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c5476...88bb6eb. Read the comment docs.

@ajkeller34 ajkeller34 merged commit f6866ea into PainterQubits:master Feb 22, 2020
@ajkeller34
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding with digits/sigdigits
3 participants