Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TaskFlow] Fix pir for taskflow #9822

Merged

Conversation

DrownFish19
Copy link
Collaborator

@DrownFish19 DrownFish19 commented Jan 24, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

Fix taskflow when PIR=ON.

修复:

Copy link

paddle-bot bot commented Jan 24, 2025

Thanks for your contribution!

ZHUI
ZHUI previously approved these changes Jan 24, 2025
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 14.47368% with 65 lines in your changes missing coverage. Please review.

Project coverage is 51.40%. Comparing base (60ef0af) to head (a687b6f).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...addlenlp/taskflow/zero_shot_text_classification.py 0.00% 24 Missing ⚠️
paddlenlp/taskflow/task.py 7.14% 13 Missing ⚠️
...addlenlp/taskflow/multimodal_feature_extraction.py 11.11% 8 Missing ⚠️
paddlenlp/generation/utils.py 0.00% 6 Missing ⚠️
paddlenlp/server/predictor.py 16.66% 5 Missing ⚠️
paddlenlp/utils/env.py 60.00% 4 Missing ⚠️
paddlenlp/transformers/semantic_search/modeling.py 0.00% 3 Missing ⚠️
...dlenlp/experimental/autonlp/text_classification.py 0.00% 1 Missing ⚠️
paddlenlp/taskflow/text_similarity.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9822   +/-   ##
========================================
  Coverage    51.40%   51.40%           
========================================
  Files          745      745           
  Lines       118373   118386   +13     
========================================
+ Hits         60853    60862    +9     
- Misses       57520    57524    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -25,15 +25,19 @@
import paddle
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此文件经过pre-commit修改,多为格式修改

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Feb 11, 2025
@PaddlePaddle PaddlePaddle unlocked this conversation Feb 11, 2025
ZHUI
ZHUI previously approved these changes Feb 12, 2025
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…h19/PaddleNLP into dev_20250124_fix_taskflow_infer
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ DrownFish19
✅ Fantasy-02
❌ ZHUI
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -26,14 +26,19 @@
import paddle.distributed as dist
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit 修改

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 777fc27 into PaddlePaddle:develop Feb 20, 2025
6 of 12 checks passed
DrownFish19 added a commit to DrownFish19/PaddleNLP that referenced this pull request Feb 20, 2025
* fix pir for taskflow

* update suffix for PIR(ON/OFF)

* fix and revert skip

* update dependency_parsing

* fix pir bug

* fix pir bug

* fix lint

* fix ci

* disable test case

---------

Co-authored-by: Zhong Hui <[email protected]>
Co-authored-by: Fantasy-02 <[email protected]>
@DrownFish19 DrownFish19 deleted the dev_20250124_fix_taskflow_infer branch February 20, 2025 03:42
ZHUI added a commit that referenced this pull request Feb 27, 2025
* [TaskFlow] Fix pir for taskflow (#9822)

* fix pir for taskflow

* update suffix for PIR(ON/OFF)

* fix and revert skip

* update dependency_parsing

* fix pir bug

* fix pir bug

* fix lint

* fix ci

* disable test case

---------

Co-authored-by: Zhong Hui <[email protected]>
Co-authored-by: Fantasy-02 <[email protected]>

* [LLM-IE] Add pp-uie to Taskflow (#9845)

* fix taskflow

* add llm/ie for SFT of ie task

* remove data folder

* update readme

* add taskflow

* remove taskflow

* add sft for ie task

* add multi_stage_predict of taskflow

* fix some bug and rename qwen2 as uie-llm

* fixed test and lint

* fixed test and lint

* fixed test and lint

* update 0109

* update 0109

* update 0113

* updaate 0113

* remove static mode in taskflow

* update 0115

* update 0115

* update 0115

* update 0116

* update 0116

* update readme.md

* update readme.md

* update 0116

* update taskflow.py and readme.md

* rename model name

* update

* [DOC] Update README for PP-UIE (#9911)

* update doc for pp-uie

* update

* update

* [taskflow] Fix taskflow bug (#9930)

* fix

* add doc

* update docs

* add experiment

* update readme.md

---------

Co-authored-by: DrownFish19 <[email protected]>

---------

Co-authored-by: Zhong Hui <[email protected]>
Co-authored-by: Fantasy-02 <[email protected]>
Co-authored-by: ZiyiHuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants