-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【CINN】Add equal function for IndexExpr #68987
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
@@ -1561,6 +1561,26 @@ int64_t IndexExpr::GetLargestMutiplyPart() const { | |||
::common::errors::Unimplemented("Unsupported type of expr: %s", type())); | |||
} | |||
|
|||
int32_t IndexExpr::length(int32_t count) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果需要传入count的话,这个length作为IndexExpr的成员函数是不就不太合适了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,下个PR将其移出。
* equal IndexExpr * add comment. * fix bug * Empty-Commit * fix bug * add equal in vector * add unit test.
PR Category
CINN
PR Types
New features
Description
MulAndNormalize
func, because it has been integrated intoSimplifymul
.operator ==
func forIndexExpr
, it will compare flatten form when meetingAdd
andMul
. e.g.IsCorrectPriority
tocomparePriority
CalculateExprComplexity
tolength
, put it into IndexExpr class method.Pcard-67164